Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace distutils with packaging #11

Merged
merged 2 commits into from
May 31, 2024
Merged

Replace distutils with packaging #11

merged 2 commits into from
May 31, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 31, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved version management and dependency handling in Ultralytics THOP library.

πŸ“Š Key Changes

  • Updated the library version from 0.0.2 to 0.0.3.
  • Added packaging as a new dependency in the project.
  • Changed version checking within the code from using LooseVersion to Version for better accuracy and reliability.

🎯 Purpose & Impact

  • Enhanced Reliability: Upgrading to a new version (0.0.3) signifies improvements and possibly bug fixes, making the library more stable for users.
  • Dependency Management: Introducing the packaging module as a dependency ensures more robust version handling. This change impacts how the library interacts with different versions of PyTorch, ensuring compatibility and addressing previous limitations with version checking.
  • Accurate Version Checking: Transitioning to Version for PyTorch version comparisons eliminates potential issues with version parsing and comparison, ensuring the library functions correctly across various PyTorch versions. This change benefits users by preventing unexpected behavior due to incorrect version assumptions, especially concerning feature support and deprecations.

πŸ” In summary, these updates make the THOP library more reliable and user-friendly by improving version handling and dependency management, which enhances overall compatibility and stability.

@glenn-jocher glenn-jocher merged commit 5acf27a into main May 31, 2024
1 check passed
@glenn-jocher glenn-jocher deleted the up2 branch May 31, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant